-
Notifications
You must be signed in to change notification settings - Fork 259
chore: apply zizmor autofixes #2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR applies automated security fixes from zizmor, a GitHub Actions security linting tool. The changes focus on two main security improvements: adding persist-credentials: false to checkout actions to prevent credential exposure, and converting inline GitHub Actions expressions to environment variables to mitigate script injection vulnerabilities.
Key Changes
- Added
persist-credentials: falseto allactions/checkoutsteps across 13 workflow files - Converted inline
${{ }}expressions in shell scripts to environment variables with properenv:blocks - Renamed variable references to use shell syntax (
${VAR}) instead of GitHub Actions expression syntax
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/update_linter_versions.yml | Added persist-credentials: false to checkout action |
| .github/workflows/release_promote.yml | Converted S3 path expressions to environment variables |
| .github/workflows/release_installer.yml | Added credential persistence control and converted S3 paths to env vars |
| .github/workflows/release.yml | Added credential control and converted multiple expressions to env vars (has critical bugs) |
| .github/workflows/prepare_release.yml | Added persist-credentials: false to checkout action |
| .github/workflows/plugins.yml | Added persist-credentials: false to checkout action |
| .github/workflows/installer_test.yml | Added persist-credentials: false to checkout action |
| .github/workflows/fmt.yml | Added persist-credentials: false to checkout action |
| .github/workflows/docker.yml | Added credential control and converted digest/image expressions to env vars (has critical bug) |
| .github/workflows/cli_integration.yml | Added persist-credentials: false to checkout action |
| .github/workflows/cli.yml | Added persist-credentials: false to checkout action |
| .github/workflows/claude.yml | Added persist-credentials: false to checkout action |
| .github/workflows/changelog.yml | Added persist-credentials: false to checkout action |
| .github/workflows/build.yml | Added credential control and converted Homebrew formula expressions to env vars |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Diff Coverage for macos-15: Not applicable. There was no coverage data reported for the files in this diff. Total Coverage for macos-15: This PR will decrease coverage by 0.01%. File Coverage Changes
🛟 Help
|
|
Diff Coverage for ubuntu-latest: Not applicable. There was no coverage data reported for the files in this diff. Total Coverage for ubuntu-latest: This PR will decrease coverage by 0.01%. File Coverage Changes
🛟 Help
|
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/docker.yml:1
- The conversion is incomplete. The expression
${{ env.REGISTRY }}was not converted to an environment variable like${IMAGE_NAME}was. This creates an inconsistent pattern and the${{ env.REGISTRY }}expression should be moved to the env block and referenced as${REGISTRY}in the shell script.
name: Docker
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Write and read notes from a file to avoid quoting breaking things | ||
| echo "$ANNOUNCEMENT_BODY" > $RUNNER_TEMP/notes.txt | ||
| gh release create "v${{ steps.version.outputs.version }}" $PRERELEASE_FLAG --title "$ANNOUNCEMENT_TITLE" --notes-file "$RUNNER_TEMP/notes.txt" target/distrib/* | ||
| gh release create "v${STEPS_VERSION_OUTPUTS_VERSION}" "$PRERELEASE_FLAG" --title "$ANNOUNCEMENT_TITLE" --notes-file "$RUNNER_TEMP/notes.txt" target/distrib/* |
Copilot
AI
Nov 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $PRERELEASE_FLAG should be quoted to prevent word splitting issues when it's empty or contains spaces. Change to "$PRERELEASE_FLAG".
Has not been verified yet