-
Notifications
You must be signed in to change notification settings - Fork 810
Timestamps in parakeet_runner
#16545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergennachin
merged 17 commits into
pytorch:main
from
mattjcly:matt/parakeet-timestamps-new-tokenizer-method
Jan 13, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d402b49
Update tokenizers for id_to_piece
mattjcly 0396189
Working with supported_punctuation export (don't want)
mattjcly fa3e404
Derive supported punctuation
mattjcly 62774fa
Some cleanups
mattjcly afc3427
Add DecodedToken
mattjcly 6313a49
Same token id types, some small type cleanups
mattjcly df2e8e8
Refs and decode token string overload
mattjcly 3a4a2f1
Rename to FrameAlignedToken
mattjcly 1a23c14
Helper for tokens with text info
mattjcly 0c9768d
try-catch get_tokens_with_text_info
mattjcly 365896d
Remove duplicated mock
mattjcly 08b82fd
timestamp_utils/tokenizer_utils/types re-organization
mattjcly 5c27d9d
Remove redundant check
mattjcly 9504e37
CMake lint fix
mattjcly 349d0b6
Explicit pytorch tokenizers include
mattjcly 4b5b15a
default to segement timestamps
mattjcly 7ada1eb
Default segment in readme
mattjcly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will break compat with previously exported parakeet models. I chose to do this b/c early in development and to avoid having to make a separate path that allows everything but timestamps if the new metadata isn't present.
Open to doing such a thing if reviewers feel strongly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i don't mind bc breaking at this early stage.
And it's in examples anyway not in core directory (like /extensions)