NXP backend: added Squeeze support #16540
Open
+268
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16540
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ebf1adc with merge base 7793b1d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "release notes: nxp" |
Contributor
Author
|
@pytorchbot label "module: nxp" |
pytorch-bot
bot
added
the
release notes: nxp
pytorch-bot
bot
added
the
module: nxp
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the "Squeeze" operator in the NXP backend by implementing a pass that converts squeeze operations to view operations.
Changes:
- Added
ConvertSqueezeToViewPassclass that transformsaten.squeezeoperations intoaten.viewoperations - Integrated the new pass into
NeutronAtenPassManager - Added
SqueezeAddModeltest model and comprehensive test suite covering various squeeze scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backends/nxp/aten_passes/convert_squeeze_to_view.py | Implements the pass to convert squeeze operations to view operations, following the same pattern as the existing unsqueeze pass |
| backends/nxp/aten_passes/neutron_aten_pass_manager.py | Integrates ConvertSqueezeToViewPass into the pass manager and updates copyright year |
| backends/nxp/tests/models.py | Adds SqueezeAddModel test helper class for testing squeeze operations |
| backends/nxp/tests/test_convert_squeeze_to_view.py | Comprehensive test suite covering squeeze with None dim, specific dims, negative dims, lists/tuples, and partial/full dimension overlaps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
novak-vaclav
force-pushed
the
feature/EIEX-673-add-support-for-squeeze-operator
branch
from
67fb8ba to
ebf1adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds support for "Squeeze" operator
Test plan
tests can be manually run using
pytest -c /dev/null backends/nxp/tests/cc @robert-kalmar @JakeStevens @digantdesai @MartinPavella