Arm backend: Propagate and validate device in TOSAQuantizer #16538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable running eager mode on a device after quantizing. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I7c9e957a17b0263e3332fe7360b1d483c7a17cb7
Erik-Lundell
requested review from
digantdesai and
kimishpatel
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16538
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 53c0ce3 with merge base dbf3c37 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
meta-cla
bot
added
the
CLA Signed
zingo
approved these changes
Jan 13, 2026
zingo
requested changes
Jan 13, 2026
Collaborator
zingo
left a comment
zingo
left a comment
There was a problem hiding this comment.
OK to merge after all Arm tests have PASSED OK there seem to be a few fail :(
And needs a review of non Arm file change maybe @SS-JIA or @metascroy can assist.
SS-JIA
approved these changes
Jan 13, 2026
Contributor
SS-JIA
left a comment
SS-JIA
left a comment
There was a problem hiding this comment.
Change in replace_scalar_with_tensor LGTM.
Btw, I think the one failure is safe to ignore/bypass. The job has been failing recently cc: @kirklandsign
zingo
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable running eager mode on a device after quantizing.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai