-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ADD restore ssr in angular example #7619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@pubkey have you had the chance to look at my pr? i can see that CI is failing cause the ts-node package is missing don't know if it can be useful, but i could work also on an update of the angular app. currently it's using v17 which is quite old and it does not use any of the features introduced by the new versions (standalone components, signals) |
|
@trik Yes if you find the time, please update the angular version. |
|
@pubkey the angular app updated to v21 is ready we have only two relevant changes:
|
If I remember correctly, this was to make the RxDatabase starting up even before angular itself is loading, to this improves the time to interaction because when angular starts the database is already there. |
yeah, i get it, the app initializer is still there, i only removed the manual Injector injection i see that ci is failing, sorry i was focused on ssr and i did not run the other tests, the hero list component template has changed a little bit, that's why they are failing i guess |
Updates the Angular example application to version 21 and configures it for server-side rendering (SSR). This involves migrating from modules to standalone components, updating the build process to use the 'application' builder, and configuring SSR-specific build configurations.
|
@pubkey the test execution should be good now, i tested also the other steps of the CI flow |
This PR contains:
Describe the problem you have without this PR
Restore server-side-rendering in angular examples and re-enable ssr tests. It was removed when the angular example has been updated to angular 17