Skip to content

Conversation

@A-L-A
Copy link
Contributor

@A-L-A A-L-A commented Jun 17, 2025

Fixes #3504

Changes:

  • Marked 1.11.7 as '(Default)' and 2.0.3 as '(Beta)'
  • Updated p5Versions array format for both versions
  • Enhanced VersionPicker.jsx to handle both object and string version formats
  • Maintained backward compatibility with existing version switching

TESTING PERFORMED:

  1. Manual Testing:
  • Manual verification of label display for all version types
  • Confirmed version switching works between:
    • Labeled versions (default/beta)
    • Unlabeled versions
  1. Automatic Testing:
    -All existing tests pass
    -No linting errors
    -Note: No pre-existing tests for this component

Notes:

  • React lifecycle warnings shown are pre-exist

- Marked 1.11.7 as '(Default)' and 2.0.3 as '(Beta)'
- Updated version matching logic to handle object format
- Maintained backward compatibility with string versions
@welcome
Copy link

welcome bot commented Jun 17, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@shaswata-26 shaswata-26 mentioned this pull request Sep 4, 2025
4 tasks
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @A-L-A!

I'm sorry that it took so long to get back to this, but this looks overall looks great to me! I only added a minor change to update it to the current latest versions and to resolve a merge conflict.

I'm going to merge this in, but please feel free to follow up with any changes you'd like to add here! Thanks so much again for your work, I really appreciate it!

@raclim raclim merged commit 29da68a into processing:develop Dec 4, 2025
1 check passed
@A-L-A
Copy link
Contributor Author

A-L-A commented Dec 4, 2025

@raclim the pleasure was mine 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resetting to p5.js default version

2 participants