fix(pkg-py): correct DateTime type mapping in DataFrameSource schema #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataFrameSource.get_schema was mapping nw.Datetime to "TIME" instead of "TIMESTAMP". A datetime (date + time) should be represented as TIMESTAMP, not TIME (which is for time-only values). Also updated the range check to include TIMESTAMP instead of TIME so that datetime columns continue to show range information in the schema. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds a test that verifies datetime columns in DataFrameSource are correctly mapped to TIMESTAMP (not TIME) in the schema output. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DataFrameSource.get_schemamappingnw.Datetimeto"TIME"instead of"TIMESTAMP"TIMESTAMPso datetime columns continue to show range infoDetails
A datetime (date + time) should be represented as
TIMESTAMP, notTIME(which is for time-only values). This affects the schema information provided to the LLM for query generation.Test plan
pytest pkg-py/tests/test_datasource.py)🤖 Generated with Claude Code