-
Notifications
You must be signed in to change notification settings - Fork 132
External code editor linking #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for external code editor linking, enabling users to open scripts directly in VSCode or Cursor via deep links. Users can now select their preferred code editor from a new setting in the Editor settings panel.
Key changes:
- Added a new "Code Editor" setting in the Editor settings panel with options for Web, VSCode, and Cursor
- Modified the code editor picker to detect the selected IDE and generate deep links for VSCode and Cursor
- Added TypeScript type definitions to the AssetInspector class for improved type safety
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/editor/toolbar/toolbar-code-editor.ts | Implements deep linking logic for VSCode and Cursor, checking the user's code editor preference and opening the appropriate editor |
| src/editor/inspector/settings-panels/editor.ts | Adds the "Code Editor" dropdown setting with Web, VSCode, and Cursor options |
| src/editor/inspector/asset.ts | Adds TypeScript type definitions to the AssetInspector class and fixes style.flex type issues (number to string) |
| src/editor/attributes/reference/settings.ts | Adds documentation for the new code editor setting reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
There is also one more case in launcher, if runtime error happens, clicking on script in a bottom panel, will open IDE and highlight the necessary line (with error). |
| }, | ||
| { | ||
| v: 'vscode', | ||
| t: 'VSCode' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| t: 'VSCode' | |
| t: 'VS Code' |
|
Before this is deployed, please test dramatically, and provide some beta access to those users who can test it in real environment. Many attempts of using VSCode/Claudie with Editor, so far were not possible due to bugs and issues. |
Important
Requirements
What's Changed
Preview