Skip to content

Conversation

@jason-lynch
Copy link
Member

@jason-lynch jason-lynch commented Jan 14, 2026

Summary

Adds StopInstance and StartInstance to the client package. These endpoints have existed for a while, but were missing from this package.

Testing

Nothing uses this currently.

Summary by CodeRabbit

  • New Features
    • Added the ability to start instances.
    • Added the ability to stop instances.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Two new methods, StopInstance and StartInstance, are added to the Client interface and implemented in SingleServerClient and MultiServerClient. SingleServerClient delegates to the underlying API client with error translation, while MultiServerClient delegates to the live server instance.

Changes

Cohort / File(s) Change Summary
Start/Stop Instance Methods
client/interface.go, client/multi.go, client/single.go
Added StopInstance and StartInstance method signatures to Client interface; implemented in SingleServerClient with c.api delegation and translateErr error handling; implemented in MultiServerClient with liveServer delegation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 New methods hop into view, start and stop with grace,
Delegating through servers at a steady pace,
Clean patterns repeated across the files with care,
Instances rise and rest—now the clients are aware! 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing several required template sections including Changes, Testing details, Checklist items, and Notes for Reviewers. Complete the PR description by adding the Changes section with bulleted list, detailed Testing commands/steps, marking all Checklist items, and adding Notes for Reviewers if applicable.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding stop/start instance functionality to the client package, following Conventional Commits format.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from ff49726 to d2d01f2 Compare January 15, 2026 13:52
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from 0772793 to 428a971 Compare January 15, 2026 13:52
@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from d2d01f2 to 0e390fb Compare January 15, 2026 14:00
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from 428a971 to ee91d28 Compare January 15, 2026 14:00
@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from 0e390fb to a96f2df Compare January 15, 2026 14:04
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from ee91d28 to 8fb80de Compare January 15, 2026 14:04
@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from a96f2df to bfec708 Compare January 15, 2026 17:36
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from 8fb80de to 160d67f Compare January 15, 2026 17:36
@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from bfec708 to f1e442e Compare January 15, 2026 21:53
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from 160d67f to e45c0d5 Compare January 15, 2026 21:53
@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from f1e442e to 0fc3bee Compare January 15, 2026 21:56
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from e45c0d5 to d3428ee Compare January 15, 2026 21:56
@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from 0fc3bee to b59faae Compare January 15, 2026 23:04
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from d3428ee to cf2f790 Compare January 15, 2026 23:04
@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from b59faae to 9d79fdf Compare January 15, 2026 23:29
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from cf2f790 to 3373af8 Compare January 15, 2026 23:30
@jason-lynch
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from 9d79fdf to cd8fd02 Compare January 16, 2026 14:24
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from 3373af8 to 59940ea Compare January 16, 2026 14:24
@jason-lynch jason-lynch force-pushed the feat/PLAT-347/remove-host-task branch from cd8fd02 to f456234 Compare January 16, 2026 21:51
These endpoints were missing from the client package.
@jason-lynch jason-lynch force-pushed the feat/add-stop-start-instance-to-client branch from 59940ea to cd5332b Compare January 16, 2026 21:51
Copy link
Contributor

@rshoemaker rshoemaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from feat/PLAT-347/remove-host-task to main January 18, 2026 15:50
@jason-lynch jason-lynch merged commit 90a58bf into main Jan 18, 2026
3 checks passed
@jason-lynch jason-lynch deleted the feat/add-stop-start-instance-to-client branch January 18, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants