fix: Dockerfile - consolidate build dependencies before PHP extension installation #1564
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Docker build failure when upgrading to PHP 8.3+ with sockets extension. The issue occurred because build tools (gcc, make, autoconf) were being installed after attempting to compile PHP extensions, causing the build to fail with exit code 2. Changes: - Consolidated all dependencies in single RUN command with --no-cache - Added linux-headers, autoconf, build-base before extension compilation - Added sockets extension to docker-php-ext-install - Upgraded default PHP version from 8.1 to 8.3 This ensures build tools are available before pecl/docker-php-ext-install attempts to compile extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Problem
Pest 4.x requires PHP 8.3+ minimum and the sockets extension. The existing Dockerfile was using PHP 8.1 and didn't include sockets.
Solution
Reorganize Dockerfile to meet Pest 4 requirements and fix the build order:
apk addcommands into a single RUN with--no-cachelinux-headers autoconf build-basebeforedocker-php-ext-installChanges
Before
Before (PHP 8.1, no sockets, wrong build order)
After (PHP 8.3, sockets added, correct build order)
Testing