Version 1.4.1 Adding license check #2
Conversation
NicolasMarlier
force-pushed
the
nma/v1-4-1
branch
from
a9ad2ab to
6b0559a
Compare
| - - :approve | ||
| - Pennylane | ||
| - :why: Our own software | ||
| - - :approve | ||
| - pennylane | ||
| - :why: Our own software |
There was a problem hiding this comment.
why putting it twice?
| - - :approve | |
| - Pennylane | |
| - :why: Our own software | |
| - - :approve | |
| - pennylane | |
| - :why: Our own software | |
| - - :approve | |
| - Pennylane | |
| - :why: Our own software | |
| - - :approve | |
| - pennylane | |
| - :why: Our own software |
There was a problem hiding this comment.
ah case sensitive?
I'm not sure I get where this is used
| - - :approve | ||
| - sidekiq | ||
| - :why: We have purchased a commercial license | ||
| - - :approve | ||
| - sidekiq-pro | ||
| - :why: We have purchased a commercial license | ||
| - - :approve | ||
| - hexapdf | ||
| - :why: We have purchased a commercial license | ||
| - - :approve | ||
| - fintecture | ||
| - :why: Covered by our commercial relationship |
There was a problem hiding this comment.
we don't really have this in this repo, no?
There was a problem hiding this comment.
I think it's because the file has been copy-pasted from jeancaisse. We can limit this file to line 35 because below that line are the exceptions for dependencies that are authorized on a case-by-case basis (or we can also keep it as is).
gterral
left a comment
gterral
left a comment
There was a problem hiding this comment.
I would clean the file to only contains what's relevant to this repo.
Otherwise I would use a github action to sync this file with the one in jeancaisse
|
Hello @NicolasMarlier @ccfz , could we merge this PR, so that we can close the non-conformity? 🙏 |
No description provided.