Adds zoom fit selected and zoom fit all functionalities. #509

Gabrielnmds · 2025-12-17T18:43:50Z

Type of change

New feature

Description

The zoom fit selected and zoom fit all features allow for the user to change focus between one, some or all exiting nodes, fitting them in the view accordingly. The video below demonstrates both functionalities:

Zoom_fit_test.mp4

Testing

Qt version tested:
Existing tests still pass

Integrate upstream

…for error msg

…-from-nodedelegatemodel Add UI update signal

Adds NodeProcessingStatus

…-method Add setBackgroundColor support

* improves NodeValidationState struct * qt6 for linux-gcc * Adds node nickname functionality * Adjust label layout * improve caption and nickname dynamic * Add editable nickname label * add correct caption dynamic, as well as labelEdit max size * fix alignment issues between nickname and node caption * revert workflows change * fix segfault detected in dataflowgraphmodel tests * produces optional nickname structure and adds example * fix typo in spacing method and attribute * uniformizes icon files attributes * removes commented code * improves processing status icon resolution * solves situations where icons should not appear * adds docstring to each nodeprocessingstatus * adds possibility to change the node processing status icon style * moves all status logic to NodeStyle * removes unnecessary code * adds declaration of QPixmap --------- Co-authored-by: Taiguara Tupinambás <[email protected]> Co-authored-by: Gabrielnmds <[email protected]>

…o upstream_zoom_fit

Llcoolsouder

The previous version of contextMenuEvent allows subclasses to completely customize what shows in the context menu. This change would make it so every subclass gets the zoom actions menu (but only if connected to a DataFlowGraphModel).

It might be more in the spirit to the original to keep the new zoom actions as public methods, but leave them disconnected, allowing end users to connect them where they see fit. (We could have a whole collection of inherited default impl actions that could be useful in this way.)

src/GraphicsView.cpp

src/DataFlowGraphModel.cpp

Llcoolsouder · 2026-01-12T17:29:55Z

src/GraphicsView.cpp

 {
-    if (itemAt(event->pos())) {
-        QGraphicsView::contextMenuEvent(event);
-        return;
-    }
+    QGraphicsView::contextMenuEvent(event);
+    QMenu *menu = nullptr;

-    if (!nodeScene()) return;
+    bool isZoomFitMenu = false;

-    auto const scenePos = mapToScene(event->pos());
+    auto *dfModel = &nodeScene()->graphModel();
+    auto n = qgraphicsitem_cast<NodeGraphicsObject *>(itemAt(event->pos()));

-    QMenu *menu = nodeScene()->createSceneMenu(scenePos);
+    if (dfModel && n) {
+        isZoomFitMenu = dfModel->nodeZoomFitMenu(n->nodeId());
+    }
+
+    if (itemAt(event->pos()) && isZoomFitMenu) {
+        menu = nodeScene()->createZoomMenu(mapToScene(event->pos()));
+    } else if (!itemAt(event->pos())) {
+        menu = nodeScene()->createSceneMenu(mapToScene(event->pos()));
+    }


A couple thoughts here:

There's already a signal we could connect to for node-specific context menus (i.e. on node right clicked) so this might not actually be the best place for checking for itemAt() and calling our menu code.
https://github.com/search?q=repo%3Apaceholder%2Fnodeeditor%20nodeContextMenu&type=code

Zoom to fit selected (or all) aren't really specific to the node you're right clicking. Shouldn't these menu items be added to the more general scene menu? That way, right clicking empty space brings up the zoom options, but right clicking a node brings up the node-specific actions.

Okay, I'll check that signal and try changing how the verification and call are made. Thanks for the suggestion!

Regarding the zoom fit options, the feature works as follows:

Zoom Fit Selected zoom fits the selected nodes.

Zoom Fit All zoom fits all the nodes in the canvas.

The right-click context menu is only triggered when the right button is on a selected node because right-clicking on the empty screen triggers the node context menu. Therefore, we thought it would be better to do this so as not to create an extensive context menu with multiple options (i.e., nodes and node-specific actions).

Remember that this is just one example of how to use the Zoom Fit feature. Therefore, this feature can be implemented in the application in many ways by the developer.

Tagging @paceholder for final review on this bit.
If he's cool with it, I'm not going to dig my heels in.

wrong account

Llcoolsouder

It looks like a bunch of other changes have leaked into this PR.

This reverts commit e828567, reversing changes made to 8d6c26b.

g-abilio · 2026-01-15T15:26:53Z

It looks like a bunch of other changes have leaked into this PR.

Solved!

tatatupi and others added 30 commits June 20, 2025 15:26

Updates fork from upstream

2edfb0b

Integrate upstream

wip: adds NodeValidationState info to NodeDelegateModel

988ce45

makes the nodeObject red in case of invalid state and adds a tooltip …

1c84750

…for error msg

adds warning state and adapts calculator example

3007c23

adds validation icon and adapts calculation example

129d414

core improvements to develop node processing status

e0b0c4a

first commit on the creation of a processing status example

e002f5b

fixes nodeprocessingstatus cast

985b638

creation of random gen example, and fix of icon color

3f55e35

Connect delegate UI update signal

50c6bec

fix random number node dynamic

1c09ecf

Merge pull request #5 from fabns-nano/codex/add-signal-for-ui-updates…

50ce760

…-from-nodedelegatemodel Add UI update signal

clean up test code in multiplication node

f2c120f

Add per-node background color API

965eb15

Updates fork from upstream

545c018

adds version to Catch2 due to compatibility issues

c34e6e3

Merge branch 'paceholder:master' into master

97d48d5

Merge branch 'master' of https://github.com/paceholder/nodeeditor

89ac7f2

solves conflict

37c3bf8

revert unnecessary changes in multiplication model

b23ecc3

revert unnecessary changes

0a35f76

solve icon size and refactor NodeProcessingStatus code

a9be092

update and merge new code

5530b72

remove duplicate code

03e311a

add space to better organize processing status in node display

a87ceb2

remove processing value default value

ae3715b

fix bugs in node processing status

eedc666

add Q_DECLARE_METATYPE to solve linux build problems

1298605

declaring metatype in the correct place

47d948f

Merge pull request #6 from fabns-nano/node_processing_status

21b55ac

Adds NodeProcessingStatus

g-abilio and others added 9 commits December 3, 2025 11:20

fix undocommands module inclusion

4f1b23c

solve conflicts

87e219b

Merge pull request #7 from fabns-nano/codex/expose-setbackgroundcolor…

dea439b

…-method Add setBackgroundColor support

Merge branch 'master' of https://github.com/paceholder/nodeeditor int…

83426c7

…o upstream_zoom_fit

adds zoomFitAll and zoomFitSelected methods

422cdd5

refactor(zoom fit): minor code fixes

9fdc3e8

refactor(zoom fit): fixes code conflicts

f2473e7

Refactor(node editor): solve conflicts

bc1b6cb

Llcoolsouder reviewed Jan 5, 2026

View reviewed changes

src/GraphicsView.cpp Outdated Show resolved Hide resolved

src/GraphicsView.cpp Show resolved Hide resolved

src/GraphicsView.cpp Outdated Show resolved Hide resolved

src/GraphicsView.cpp Outdated Show resolved Hide resolved

g-abilio added 2 commits January 7, 2026 15:05

fix uninitialized variable and remove return

2b3ac01

remove bad coupling

891b702

Llcoolsouder reviewed Jan 12, 2026

View reviewed changes

src/DataFlowGraphModel.cpp Outdated Show resolved Hide resolved

Llcoolsouder reviewed Jan 12, 2026

View reviewed changes

g-abilio added 2 commits January 12, 2026 14:41

refactoring to simpler code

8d6c26b

solve conflicts

e828567

tatatupi approved these changes Jan 14, 2026

View reviewed changes

This comment was marked as duplicate.

Sign in to view

Llcoolsouder requested changes Jan 15, 2026

View reviewed changes

Revert "solve conflicts"

02b3969

This reverts commit e828567, reversing changes made to 8d6c26b.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adds zoom fit selected and zoom fit all functionalities. #509

Adds zoom fit selected and zoom fit all functionalities. #509

Gabrielnmds commented Dec 17, 2025 •

edited by tatatupi

Loading

Uh oh!

Llcoolsouder left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Llcoolsouder Jan 12, 2026

Uh oh!

g-abilio Jan 12, 2026

Uh oh!

g-abilio Jan 12, 2026

Uh oh!

Llcoolsouder Jan 15, 2026

Uh oh!

This comment was marked as duplicate.

Uh oh!

Llcoolsouder left a comment

Uh oh!

g-abilio commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Adds zoom fit selected and zoom fit all functionalities. #509

Are you sure you want to change the base?

Adds zoom fit selected and zoom fit all functionalities. #509

Conversation

Gabrielnmds commented Dec 17, 2025 • edited by tatatupi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description

Testing

Uh oh!

Llcoolsouder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Llcoolsouder Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

g-abilio Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

g-abilio Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Llcoolsouder Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

Uh oh!

Llcoolsouder left a comment

Choose a reason for hiding this comment

Uh oh!

g-abilio commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gabrielnmds commented Dec 17, 2025 •

edited by tatatupi

Loading