Fix test script quoting to run properly on Windows #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test scripts single quote the test pattern glob, which runs properly in Linux and macOS, but on Windows it results in no tests found. This then passes since no tests failed, as seen in the following log from here.
Actions Log
This traces back to the original conversion from make to npm scripts in 40ba01a, with the note "quote globs in scripts to avoid missingsubdirectories". On Linux/macOS without the quotes, or with double quotes, the
tests/unit/lib/reporters/*tests are not run, although on Windows the tests all run in those cases. Mocha was updated in #256 (from 10.3.0 to 11.1.0), and this appears to have been missed (tests run as expected in the previous commit).Keeping the globs, double quoted, but without the
--recursiveflag seems to work on all platforms. I also added the--fail-zeroflag, which will fail if no tests are found.This appears to be an instance of mochajs/mocha#4186.