adds ability to abort I2C transaction (bsv) #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QsfpModuleController: add I2C transaction timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to abort an I2C transaction. It achieves this by exposing an
abortport which will request to abort a transaction. TheI2CCorewill then gracefully end the transaction with a STOP. For writes, this means after the next ACK from the target (we'd STOP after a NACK anyway). For reads, this means to NACK after receiving the next byte from the target.Additionally, this commit uses the new abort functionality in the
QsfpModuleControllerto support timing-out an I2C transaction after a given time. Previously this could just go on forever.fixes #362