Skip to content

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Nov 28, 2024

PR 5 / ???

Implements support bundle APIs for accessing storage bundles.

Builds atop the API skeleton in:

Uses the support bundle datastore interfaces in:

Relies on the background task in:

TODO before merging:

  • Integration tests?
  • If possible, make range requests work correctly?

@smklein smklein marked this pull request as ready for review January 9, 2025 20:38
Base automatically changed from support-bundle-bg-task to main January 13, 2025 23:49
Copy link
Contributor

@wfchandler wfchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smklein, I have no complaints with this one. I'm not very familiar with Progenitor, though, so take my approval with a grain of salt.

@smklein
Copy link
Collaborator Author

smklein commented Jan 15, 2025

Thanks @smklein, I have no complaints with this one. I'm not very familiar with Progenitor, though, so take my approval with a grain of salt.

I've been discussing some follow-ups with @ahl in both:

I think the resolution here will require progenitor and dropshot changes to be done - I can file some issues related to this usage for support bundles before merging.

@smklein
Copy link
Collaborator Author

smklein commented Jan 15, 2025

Filed #7356

@smklein smklein merged commit a33943f into main Jan 15, 2025
17 checks passed
@smklein smklein deleted the support-bundle-wire-up-http-endpoints branch January 15, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet