Rabbitmq vhost and user support #658

lmiccini · 2025-12-15T16:42:27Z

Add new notificationsBus interface to hold cluster, user and vhost names for optional usage.
The controller adds these values to the TransportURL create request when present.

Additionally, we migrate RabbitMQ cluster name to RabbitMq config struct
using DefaultRabbitMqConfig from infra-operator to automatically
populate the new Cluster field from legacy RabbitMqClusterName.

Example usage:

  spec:
    notificationsBus:
      cluster: rabbitmq
      user: custom-user
      vhost: custom-vhost

Jira: https://issues.redhat.com/browse/OSPRH-22689

softwarefactory-project-zuul · 2025-12-15T16:59:42Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6c51862b4137480b875966bace270970

❌ openstack-k8s-operators-content-provider FAILURE in 16m 10s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

lmiccini · 2025-12-16T06:08:03Z

/test keystone-operator-build-deploy-kuttl

lmiccini · 2025-12-16T06:08:07Z

recheck

softwarefactory-project-zuul · 2025-12-16T06:24:24Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3ba3f223dd4d4dbd88230f3ba6d9b1de

❌ openstack-k8s-operators-content-provider FAILURE in 15m 11s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

lmiccini · 2025-12-16T07:02:56Z

/test keystone-operator-build-deploy-kuttl

lmiccini · 2025-12-16T07:04:39Z

recheck

softwarefactory-project-zuul · 2025-12-16T07:21:36Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3232fc4e308b485789ba835467ff6b7c

❌ openstack-k8s-operators-content-provider FAILURE in 15m 49s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

softwarefactory-project-zuul · 2025-12-17T05:09:11Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/953ff682988b46989b4fe010f51031d2

❌ openstack-k8s-operators-content-provider FAILURE in 8m 55s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

lmiccini · 2025-12-17T05:17:28Z

/test functional

softwarefactory-project-zuul · 2025-12-17T08:51:32Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/efc251acb845441baf501e7d4b266852

❌ openstack-k8s-operators-content-provider FAILURE in 18m 38s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

softwarefactory-project-zuul · 2026-01-09T06:48:29Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5cacdd337da44d858f06377c996132b9

❌ openstack-k8s-operators-content-provider FAILURE in 6m 14s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

lmiccini · 2026-01-09T08:14:27Z

/test functional

softwarefactory-project-zuul · 2026-01-19T10:25:27Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/keystone-operator for 658,f6db8e17b38af1152c6dec40e3aaf293f8982cae

softwarefactory-project-zuul · 2026-01-19T12:29:34Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/80e9475688c645fbbf3a1d936043a028

❌ openstack-k8s-operators-content-provider FAILURE in 6m 39s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

softwarefactory-project-zuul · 2026-01-19T13:54:06Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/209bb982152a4bea908c9dde9c049795

❌ openstack-k8s-operators-content-provider FAILURE in 16m 30s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

lmiccini · 2026-01-20T07:01:17Z

/test keystone-operator-build-deploy-kuttl

lmiccini · 2026-01-20T07:01:21Z

recheck

softwarefactory-project-zuul · 2026-01-20T07:18:17Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2dc739eed3de40fcbb81d83d91443ce0

❌ openstack-k8s-operators-content-provider FAILURE in 15m 40s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

internal/controller/keystoneapi_controller.go

test/functional/keystoneapi_controller_test.go

softwarefactory-project-zuul · 2026-01-20T12:18:27Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/keystone-operator for 658,c5a3cfd6e0547c7e7ef33d39b81013ec6ed54468

lmiccini · 2026-01-20T12:47:00Z

/test functional

lmiccini · 2026-01-20T15:01:07Z

/test functional

xek

/lgtm Thanks!

openshift-ci · 2026-01-22T11:52:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, xek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [xek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add new notificationsBus interface to hold cluster, user and vhost names for optional usage. The controller adds these values to the TransportURL create request when present. Additionally, we migrate RabbitMQ cluster name to RabbitMq config struct using DefaultRabbitMqConfig from infra-operator to automatically populate the new Cluster field from legacy RabbitMqClusterName. Example usage: spec: notificationsBus: cluster: rabbitmq user: custom-user vhost: custom-vhost Jira: https://issues.redhat.com/browse/OSPRH-22689

openshift-ci · 2026-01-22T16:48:43Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2026-01-22T17:13:12Z

@lmiccini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/precommit-check	`8469bde`	link	true	`/test precommit-check`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lmiccini · 2026-01-23T06:21:00Z

/test keystone-operator-build-deploy-kuttl

openshift-ci bot requested review from afaranha and stuggi December 15, 2025 16:42

lmiccini force-pushed the rabbitmq_vhosts branch 3 times, most recently from e142029 to 971035f Compare December 17, 2025 04:59

lmiccini requested a review from fmount December 17, 2025 05:25

lmiccini force-pushed the rabbitmq_vhosts branch 2 times, most recently from 9bd3519 to 12cfe9d Compare December 17, 2025 08:28

lmiccini force-pushed the rabbitmq_vhosts branch 3 times, most recently from 2a78269 to e3a40c2 Compare December 19, 2025 14:01

lmiccini force-pushed the rabbitmq_vhosts branch from e3a40c2 to 3c505b3 Compare January 9, 2026 06:41

lmiccini force-pushed the rabbitmq_vhosts branch 2 times, most recently from a72444a to 875b9a7 Compare January 9, 2026 08:08

lmiccini force-pushed the rabbitmq_vhosts branch 2 times, most recently from 94848a8 to 7d70fe3 Compare January 9, 2026 14:11

lmiccini force-pushed the rabbitmq_vhosts branch from 7d70fe3 to f6db8e1 Compare January 19, 2026 10:25

lmiccini force-pushed the rabbitmq_vhosts branch from 69849ff to 495c67d Compare January 19, 2026 13:27

lmiccini force-pushed the rabbitmq_vhosts branch from 495c67d to b9fdaa6 Compare January 20, 2026 08:26

mauricioharley requested changes Jan 20, 2026

View reviewed changes

internal/controller/keystoneapi_controller.go Outdated Show resolved Hide resolved

internal/controller/keystoneapi_controller.go Outdated Show resolved Hide resolved

test/functional/keystoneapi_controller_test.go Show resolved Hide resolved

openshift-ci bot assigned mauricioharley Jan 20, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from b9fdaa6 to c5a3cfd Compare January 20, 2026 12:18

openshift-merge-robot added the needs-rebase label Jan 20, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from c5a3cfd to b4b72b1 Compare January 20, 2026 12:30

openshift-merge-robot removed the needs-rebase label Jan 20, 2026

dmendiza self-requested a review January 20, 2026 16:07

lmiccini force-pushed the rabbitmq_vhosts branch from b4b72b1 to c22a0a3 Compare January 21, 2026 06:15

xek approved these changes Jan 22, 2026

View reviewed changes

openshift-ci bot assigned xek Jan 22, 2026

openshift-ci bot added the lgtm label Jan 22, 2026

openshift-ci bot added the approved label Jan 22, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from c22a0a3 to 8469bde Compare January 22, 2026 16:48

openshift-ci bot removed the lgtm label Jan 22, 2026

lmiccini added the do-not-merge/hold label Jan 22, 2026

Rabbitmq vhost and user support #658

Are you sure you want to change the base?

Rabbitmq vhost and user support #658

Uh oh!

Conversation

lmiccini commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Dec 15, 2025

Uh oh!

lmiccini commented Dec 16, 2025

Uh oh!

lmiccini commented Dec 16, 2025

Uh oh!

softwarefactory-project-zuul bot commented Dec 16, 2025

Uh oh!

lmiccini commented Dec 16, 2025

Uh oh!

lmiccini commented Dec 16, 2025

Uh oh!

softwarefactory-project-zuul bot commented Dec 16, 2025

Uh oh!

softwarefactory-project-zuul bot commented Dec 17, 2025

Uh oh!

lmiccini commented Dec 17, 2025

Uh oh!

softwarefactory-project-zuul bot commented Dec 17, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jan 9, 2026

Uh oh!

lmiccini commented Jan 9, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 19, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 19, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 19, 2026

Uh oh!

lmiccini commented Jan 20, 2026

Uh oh!

lmiccini commented Jan 20, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Jan 20, 2026

Uh oh!

lmiccini commented Jan 20, 2026

Uh oh!

lmiccini commented Jan 20, 2026

Uh oh!

xek left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 22, 2026

Uh oh!

openshift-ci bot commented Jan 22, 2026

Uh oh!

openshift-ci bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmiccini commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lmiccini commented Dec 15, 2025 •

edited

Loading

openshift-ci bot commented Jan 22, 2026 •

edited

Loading