Refactor LetterOpenerWeb mounting condition#3693
Open
chennes wants to merge 2 commits intoopenSUSE:masterfrom
Open
Refactor LetterOpenerWeb mounting condition#3693chennes wants to merge 2 commits intoopenSUSE:masterfrom
chennes wants to merge 2 commits intoopenSUSE:masterfrom
Conversation
Prevent any attempt to access `LetterOpenerWeb` when running in production.
Contributor
Author
|
The linter is complaining about the block length, which went from 202 to 204 lines -- it's beyond my meager Ruby skills to refactor this code in any sensible way. And of course IMO it doesn't make sense to do so as part of this PR :). At any rate, if that's what's holding this up please let me know, I don't know this project's policy on CI failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent any attempt to access
LetterOpenerWebwhen running in production.Checklist
masterbranch.Short description of what this resolves/which issues does this fix?:
LetterOpenerWebbecause of the way Rails runs the existing line. This PR refactors the check to ensure that only the development environment attempts to access it.Changes proposed in this pull request:
LetterOpenerWebto check for the dev environment before attempting to access it.