Issue 3027 #3516
Issue 3027 #3516
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
gouttegd
left a comment
gouttegd
left a comment
There was a problem hiding this comment.
It looks like you inadvertently created two “facial crest” terms.
And the first one has logical axioms that can’t be represented in OBO.
|
@meghalithic There are a lot of minor conflicts, likely due to the fact that the first commit of the PR was done nearly two years ago. Do you want me to resolve them for you? |
|
@gouttegd yes please! Thank you! |
gouttegd
left a comment
gouttegd
left a comment
There was a problem hiding this comment.
The conflicts have been fixed (which makes the changes much easier to review now that they are no longer interspersed with unrelated changes).
The logical definition of 'nasal notch' is problematic, see below.
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
@matentzn Should be ready for rebase since all the reviews have been completed. May encounter issue during rebasing replacing |
This PR modifies some logical definitions. See details below:Number of classes with modified logical definitions: 1 facial crestNo changes in inferred subclasses. |
Replaced 'intersection_of' with 'is_a' for the facial crest term to correct its classification. Removed the accidentally added obsolete term 'Facial crest' (UBERON:8500008) for ontology cleanup.
Corrected the spelling of the synonym from 'nasoincisve notch' to 'nasoincisive notch' for UBERON:8500006 in the ontology file.
issue #3027
creating the following terms: facial crest, nasal notch, and staphylon