This repository was archived by the owner on Aug 30, 2025. It is now read-only.
Adds environment variable for table sync max currency limit #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3252 +/- ##
==========================================
- Coverage 23.49% 23.48% -0.02%
==========================================
Files 387 387
Lines 44370 44480 +110
==========================================
+ Hits 10426 10445 +19
- Misses 32887 32976 +89
- Partials 1057 1059 +2 ☔ View full report in Codecov by Sentry. |
Benchstat Geomean Results-0.66% sec/op, -0.02% B/op, 0.00% allocs/op Benchstat results |
nickzelei
reviewed
Feb 12, 2025
Comment on lines
129
to
131
| {{- if .Values.tableSync.maxConcurrency }} | ||
| TABLESYNC_MAX_CONCURRENCY: {{ .Values.tableSync.maxConcurrency }} | ||
| {{- end }} |
Member
There was a problem hiding this comment.
The if wrapper is not required because you've set it as a default value in the values.yaml
|
|
||
| func getTableSyncMaxConcurrency() int { | ||
| maxConcurrency := viper.GetInt("TABLESYNC_MAX_CONCURRENCY") | ||
| if maxConcurrency == 0 { |
Member
There was a problem hiding this comment.
Best to change this to <=0 to prevent people from setting it to something like -1
nickzelei
approved these changes
Feb 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.