[main] Fix: Board cannot be undeleted

[theoholl]

• Resolves: Boards cannot be undeleted #7506
• Target version: main

Related to: #3534

Summary

On main (and maybe other branches/versions), the undelete action is broken. The web endpoint returns a 403 Permission denied error.

This is because the PermissionService::getBoard() method is called without the allowDeleted parameter (it defaults to false), and, thus, throws a DoesNotExistException error. This error is then caught in PermissionService::getPermissions(), setting both $owner = false and $acls = []. This results in all permissions being false.

This pull request adds an optional allowDeleted parameter to relevant functions.

Screencast

Screencast.Fix.mp4

[grnd-alt]

thanks for your contribution, the code changes look fine, and work as expected 🔥
The test runs seem to be unrelated!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)