Closes #21303: Cache serialized post-change data on object #21325
+21
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested review from
a team and
pheus
and removed request for
a team
pheus
reviewed
Jan 30, 2026
Contributor
pheus
left a comment
pheus
left a comment
There was a problem hiding this comment.
Thanks! Just two small nits below.
I’m not strongly opinionated about either of them, so I’m leaving this as a comment-only review and I’m happy with the PR as-is.
pheus
approved these changes
Jan 30, 2026
Contributor
pheus
left a comment
pheus
left a comment
There was a problem hiding this comment.
Awesome! Thanks, @jeremystretch !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #21303
to_objectchange()to cache the serialized data as_postchange_snapshoton the instance being serialized.get_snapshots()to check for cached serialized data before running serialization.