-
-
Notifications
You must be signed in to change notification settings - Fork 190
TASK: Raise PhpStan to level 8 - Part 1 #3515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.1
Are you sure you want to change the base?
Conversation
0ab77ed to
4064484
Compare
|
wow thanks a lot! If you need help here let me know;) Also lets ignore the style CI failures as we want to move to php cs either way and they might have different expectations again;) |
eabd7e0 to
0d20ec9
Compare
|
@mhsdesign is suggest to merge this in parts as otherwise the reviews will get really overwhelming. |
…kages and use level 3 otherwise
0d20ec9 to
5e02f0c
Compare
|
@mhsdesign yes your commits were mostly regarding flow. I cherry pick commits for each section one by one and afterwards remove breakiness and make tests green + verify neos still works. |
|
Okay so this is the final set that should be tested and go into Flow 9.1 then ill review and test that ;) Thanks for splitting this mammoth! |
|
I will try to prepare follow ups that may or may not be ready for 9.1 but imho this is about the maximal size for a pr that is chewable. So imho this can be reviewed and merged |

Raise PhpStan to level 8 for:
Neos.Flow.LogNeos.FluidAdaptorNeos.Http.FactoriesNeos.KickstarterNeos.Utility.ArraysNeos.Utility.FilesNeos.Utility.MediaTypesNeos.Utility.ObjectHandlingNeos.Utility.OpcodeCacheNeos.Utility.PdoNeos.Utility.SchemaNeos.Utility.UnicodeUpgrade instructions
No changes needed.
Review instructions
This the first of multiple PRs to cherry pick the changes from #3474 from @nezaniel and @mhsdesign step by step and fix issues and breakiness.
This is intended to be unbreaky but be the foundation for future refactorings that can at least partly be automated once we have really solid type informations.
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions