Skip to content

Conversation

@mficzel
Copy link
Member

@mficzel mficzel commented Oct 24, 2025

Raise PhpStan to level 8 for:

  • Neos.Flow.Log
  • Neos.FluidAdaptor
  • Neos.Http.Factories
  • Neos.Kickstarter
  • Neos.Utility.Arrays
  • Neos.Utility.Files
  • Neos.Utility.MediaTypes
  • Neos.Utility.ObjectHandling
  • Neos.Utility.OpcodeCache
  • Neos.Utility.Pdo
  • Neos.Utility.Schema
  • Neos.Utility.Unicode

Upgrade instructions

No changes needed.

Review instructions

This the first of multiple PRs to cherry pick the changes from #3474 from @nezaniel and @mhsdesign step by step and fix issues and breakiness.

This is intended to be unbreaky but be the foundation for future refactorings that can at least partly be automated once we have really solid type informations.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Oct 24, 2025
@mficzel mficzel force-pushed the phpstanLevel8-v3 branch 10 times, most recently from 0ab77ed to 4064484 Compare October 24, 2025 19:50
@mhsdesign
Copy link
Member

wow thanks a lot! If you need help here let me know;) Also lets ignore the style CI failures as we want to move to php cs either way and they might have different expectations again;)

@mficzel mficzel changed the base branch from 9.0 to 9.1 October 27, 2025 13:23
@mficzel mficzel changed the base branch from 9.1 to 9.0 October 27, 2025 13:23
@mficzel mficzel changed the title DRAFT: Raise PhpStan to level 8 - V3 DRAFT: Raise PhpStan to level 8 - Part 1 Oct 27, 2025
@mficzel mficzel force-pushed the phpstanLevel8-v3 branch 2 times, most recently from eabd7e0 to 0d20ec9 Compare October 27, 2025 14:05
@mficzel mficzel marked this pull request as ready for review October 27, 2025 14:05
@mficzel
Copy link
Member Author

mficzel commented Oct 27, 2025

@mhsdesign is suggest to merge this in parts as otherwise the reviews will get really overwhelming.

@mficzel mficzel changed the base branch from 9.0 to 9.1 October 27, 2025 14:07
@github-actions github-actions bot added 9.1 and removed 9.0 labels Oct 27, 2025
@mficzel mficzel requested review from mhsdesign and nezaniel and removed request for mhsdesign October 27, 2025 14:08
@mficzel mficzel changed the title DRAFT: Raise PhpStan to level 8 - Part 1 TASK: Raise PhpStan to level 8 - Part 1 Oct 27, 2025
@github-actions github-actions bot added the Task label Oct 27, 2025
@mhsdesign
Copy link
Member

oke i assume my commits will be part of another change then? idk why i did those but i probably did them to get flow back running

image

@mficzel
Copy link
Member Author

mficzel commented Oct 27, 2025

@mhsdesign yes your commits were mostly regarding flow. I cherry pick commits for each section one by one and afterwards remove breakiness and make tests green + verify neos still works.

@mhsdesign
Copy link
Member

Okay so this is the final set that should be tested and go into Flow 9.1 then ill review and test that ;) Thanks for splitting this mammoth!

@mficzel
Copy link
Member Author

mficzel commented Oct 28, 2025

I will try to prepare follow ups that may or may not be ready for 9.1 but imho this is about the maximal size for a pr that is chewable. So imho this can be reviewed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants