revmoving multiples rows with function was failing, when detected indice...

[alexmasselot]

Indices of lines to be removed are stored increasingly.

reversing the list of index solved it

[iros]

Can we separate teh #207 issue from the reversing of rows? I agree that both are issues but I don't want to bundle them in the same pull request. I reviewed the fix for #207 and that looks good. Not sure about the reversing quite yet.

[alexmasselot]

Sure! I'm not used to github and somehow it merged the two pull request.
On Oct 1, 2013 3:07 PM, "Irene Ros" [email protected] wrote:

Can we separate teh #207 issue from the reversing of rows? I agree that
both are issues but I don't want to bundle them in the same pull request. I
reviewed the fix for #207 and that looks good. Not sure about the reversing
quite yet.

—
Reply to this email directly or view it on GitHub.

[alexmasselot]

All this makes sense. Changed made and pushed

[jalada]

It seems really unnecessary to reverse the entire array for iterating. Why not just unshift instead of push so that the array is the right way round?

[alexmasselot]

Hi David,

Thanks for your email

By now way I claim that to be the best solution. I was stucked there and
found the simplest way around.
In the other hand, I put a few unit test there for that matter, so try any
solution that fit them. Isn't that the goal:)

happy coding
Alex

On Mon, Jul 14, 2014 at 6:52 AM, David Somers [email protected]
wrote:

It seems really unnecessary to reverse the entire array for iterating. Why
not just unshift instead of push so that the array is the right way round?

—
Reply to this email directly or view it on GitHub
#210 (comment).

Alexandre Masselot

http://alexandre-masselot.blogspot.com/
http://mtroopgoeswest.blogspot.com/

[jalada]

Indeed, I submitted another pull request (#223) Alex :)

[alexmasselot]

super cool!
Alex

On Wed, Jul 16, 2014 at 6:22 AM, David Somers [email protected]
wrote:

Indeed, I submitted another pull request (#223
#223) Alex :)

—
Reply to this email directly or view it on GitHub
#210 (comment).

Alexandre Masselot

http://alexandre-masselot.blogspot.com/
http://mtroopgoeswest.blogspot.com/