Add support for lambda in total_entries option#665
Open
jcoleman wants to merge 1 commit intomislav:masterfrom
Open
Add support for lambda in total_entries option#665jcoleman wants to merge 1 commit intomislav:masterfrom
total_entries option#665jcoleman wants to merge 1 commit intomislav:masterfrom
Conversation
We use the `total_entries` option to avoid doing expensive count queries (instead we run queries that limit the number of records examined, because we don't care about exact numbers above a certain amount). But we still want to retain the optimization that no query is run at all if the first page's query returns few enough records that we know we've read all of them. Hence add support for the `total_entries` option being passed as a lambda. - Updated the `total_entries` logic to allow passing a lambda that is executed only when necessary. - Retained the optimization to skip execution of the lambda when the first batch size is smaller than the limit. - Centralized the handling of `total_entries` values (both lambdas and direct values) in the `total_entries=` setter. Note: this code was authored with the help of Copilot and GPT-4o. That being said, I reviewed the resulting code, and I also applied various stylistic edits/refactors to the resulting code.
Author
|
@mislav Any chance you could take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the
total_entriesoption to avoid doing expensive count queries (instead we run queries that limit the number of records examined, because we don't care about exact numbers above a certain amount). But we still want to retain the optimization that no query is run at all if the first page's query returns few enough records that we know we've read all of them.Hence add support for the
total_entriesoption being passed as a lambda.total_entrieslogic to allow passing a lambda that is executed only when necessary.total_entriesvalues (both lambdas and direct values) in thetotal_entries=setter.Note: this code was authored with the help of Copilot and GPT-4o. That being said, I reviewed the resulting code, and I also applied various stylistic edits/refactors to the resulting code.