Logging: be more verbose for authevents #5890
Open
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Universal-Omega
requested changes
Apr 1, 2025
Check commit and GitHub actions for more details
Universal-Omega
requested changes
Apr 6, 2025
| * @param User | null $user | ||
| * @param string | null $username | ||
| */ | ||
| public static function onAuthManagerLoginAuthenticateAudit( $response, $user, $username ) { |
Member
There was a problem hiding this comment.
type hints (including return value of void) please
Member
There was a problem hiding this comment.
Also add $extraData param even if it's unused just to resemble the actual hook interface.
| * @param AuthenticationResponse $response | ||
| * @param User | null $user | ||
| * @param string | null $username | ||
| */ |
Member
There was a problem hiding this comment.
Comment can be removed if type hinting is done as mentioned above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.