Skip to content

Adjust content inset behavior for macOS #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eadron wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Adjust content inset behavior for macOS #2806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ges/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTEnhancedScrollView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ - (instancetype)initWithFrame:(CGRect)frame
// because this attribute affects a position of vertical scrollbar; we don't want this
// scrollbar flip because we also flip it with whole `UIScrollView` flip.
self.semanticContentAttribute = UISemanticContentAttributeForceLeftToRight;
#else // [macOS
// Similar to iOS's contentInsetAdjustmentBehavior fix
// For example: When using NSWindowStyleMaskFullSizeContentView (hidden title bar) and ScrollView as root,
// NSScrollView.automaticallyAdjustsContentInsets (default YES) adds contentInset.top to push content below the toolbar.
// However, React Native doesn't know about this native contentInset adjustments,causing some caltulation issues
self.automaticallyAdjustsContentInsets = NO;
#endif // [macOS]

__weak __typeof(self) weakSelf = self;
Expand Down