feat: implement getgroups and setgroups syscalls #621
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
getgroups(2)andsetgroups(2)syscalls to manage supplementary group IDs.Changes
GetgroupsandSetgroupsvariants toSyscallRequestenumsupplementary_groupsfield toCredentialsstructTask.credentialstoRefCell<Arc<Credentials>>for interior mutabilitysys_getgroups()andsys_setgroups()methodsNGROUPS_MAX(65536) constant for validationError handling
getgroups:EINVALfor negative size or buffer too small;EFAULTfor invalid pointersetgroups:EINVALfor size >NGROUPS_MAX;EFAULTfor invalid pointerTesting
test_getgroups_empty- Verifies empty initial statetest_setgroups_and_getgroups- Verifies round-trip set/gettest_getgroups_einval_buffer_too_small- Buffer validationtest_setgroups_empty- Empty groups handlingtest_getgroups_negative_size- Negative size validationtest_setgroups_too_many- NGROUPS_MAX validationRelated
This addresses P0 syscall support as mentioned in #360.