Custom Tracer & Adapter Pattern #358
Open
+558
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
reviewed
Dec 5, 2025
| self.spans: List[CustomSpan] = [] | ||
| self.current_span: Optional[CustomSpan] = None | ||
|
|
||
| def start_span(self, name: str, **attributes) -> Any: |
Contributor
There was a problem hiding this comment.
where is start_span, end_span, and start_event called?
| - Aggregate metrics for RL | ||
| """ | ||
|
|
||
| def extract(self, trace: Any) -> Optional[agl.Triplet]: |
Contributor
There was a problem hiding this comment.
that's not the interface of agent-lightning adapter.
| @@ -0,0 +1,124 @@ | |||
| # Copyright (c) Microsoft. All rights reserved. | |||
|
|
|||
| """Example: DataDog integration using custom tracer pattern. | |||
Contributor
There was a problem hiding this comment.
Keep one of them is enough. Put the other one into examples/minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discissued on PR #353 , removed math example and added a simple tracer and adapter implementation