-
Notifications
You must be signed in to change notification settings - Fork 4k
[python-package] [ci] use 'auditwheel' to check GLIBC versions for Linux wheels, update wheel tags #7134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jameslamb
wants to merge
8
commits into
master
Choose a base branch
from
use-auditwheel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Jan 19, 2026
Comment on lines
+168
to
+172
| if [[ $ARCH == "x86_64" ]]; then | ||
| PLATFORM="manylinux_2_27_x86_64.manylinux_2_28_x86_64" | ||
| else | ||
| PLATFORM="manylinux2014_aarch64.manylinux_2_17_aarch64" | ||
| fi |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice these tags are different... auditwheel found that we could cover more platforms than the tags we'd been using!!
INFO:auditwheel.main_repair:Repairing lightgbm-4.6.0.99-py3-none-linux_aarch64.whl
INFO:auditwheel.lddtree:Excluding libgomp.so.1
INFO:auditwheel.wheeltools:Previous filename tags: linux_aarch64
INFO:auditwheel.wheeltools:New filename tags: manylinux_2_17_aarch64, manylinux2014_aarch64
INFO:auditwheel.wheeltools:Previous WHEEL info tags: py3-none-linux_aarch64
INFO:auditwheel.wheeltools:New WHEEL info tags: py3-none-manylinux_2_17_aarch64, py3-none-manylinux2014_aarch64
INFO:auditwheel.main_repair:
Fixed-up wheel written to /LightGBM/dist-fixed/lightgbm-4.6.0.99-py3-none-manylinux2014_aarch64.manylinux_2_17_aarch64.whl
The x86_64 logs could support GLIBC 2.27 (Ubuntu 18.04, for example) and the aarch64 wheels could support GLIBC 2.17!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this project, we try to maintain a low-enough GLIBC requirement for Linux wheels and the prebuilt shared library via 2 mechanisms:
liblightgbm.sobuilt in CILightGBM/.ci/test.sh
Lines 58 to 62 in 56be785
manylinuximages from https://github.com/pypa/manylinuxThis proposes adding
auditwheelas a a third check to give us higher confidence that published wheels support the expected GLIBC versions, and more logs to help with debugging issues with the build process. It can also sometimes detect that an even-more-portable tag could be used, possibly allowinglightgbmto be installed on more platforms without too much new effort here 😁