-
Notifications
You must be signed in to change notification settings - Fork 817
Reserve SM 6.10 ops for GroupWaveIndex, ClusterID, TriangleObjectPosition #7995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change reserves HLSL intrinsic HL opcodes and experimental DXIL ops for GetGroupWaveIndex and GetGroupWaveCount for SM 6.10.
Note: TriangleObjectPosition requires a new DXIL intrinsic type mapping, so the operations currently return void, with TODOs for updating signatures.
|
✅ With the latest revision this PR passed the Python code formatter. |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
V-FEXrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, looks good, I didn't go cross reference the specs so I can't say for sure the specific ops have the right shape, but I imagine you did, and they'll be updated during implementation regardless
Just assign 'insts' to self.get_insts_by_names. This makes using it in main populate_categories_and_models easier in the future.
This PR reserves HLSL intrinsic ops (HL opcodes) and DXIL ops for the following features and operations:
Group Wave Index:
Clustered Geometry:
Triangle Object Positions (return void until later update):
Most file edits are auto-generated updates, except: