Extract ScubaFileUtils and add data_sink target #521
+85
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@mlunar-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92017771. |
Summary: Pull Request resolved: meta-pytorch#521 Refactor common Scuba file utilities into a shared library that can be used by both NCCLX DataTable and MCCL McclDataTable: - Add ScubaFileUtils.h/.cpp with getScubaFileName(), createScubaFile(), and getTimestamp() - Add scuba_file_utils BUCK target with shared dependencies - Add data_sink BUCK target for DataSink.h header-only library - Update DataTable.cc to use the new ScubaFileUtils functions - Update data_table BUCK target to depend on scuba_file_utils This enables code reuse and eliminates duplicate implementations of file-related utilities between the NCCLX and MCCL logging systems. Differential Revision: D92017771
mlunar-meta
force-pushed
the
export-D92017771
branch
from
d9e2dd6 to
6a05c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor common Scuba file utilities into a shared library that can be used by both
NCCLX DataTable and MCCL McclDataTable:
This enables code reuse and eliminates duplicate implementations of file-related
utilities between the NCCLX and MCCL logging systems.
Differential Revision: D92017771