Move AllReduce kernel args to Types.h (P1-D5) #515
+284
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: Move CtranKernelSendArgs, CtranKernelRecvArgs, and CtranKernelSendRecvArgs from gpe/CtranGpeDev.h to algos/SendRecv/Types.h as ctran::sendrecv::KernelSendArgs, KernelRecvArgs, and KernelSendRecvArgs respectively. Part of KernelElem cleanup Phase 1. Naming follows the convention: - Remove "Ctran" prefix - Keep "Kernel" prefix - Keep "Send/Recv/SendRecv" suffix since they're distinct types Reviewed By: elvinlife Differential Revision: D91983715
Summary: Move CtranKernelAllGatherArgs from gpe/CtranGpeDev.h to algos/AllGather/Types.h as ctran::allgather::KernelArgs. Part of KernelElem cleanup Phase 1. Naming follows the convention: - Remove "Ctran" prefix - Keep "Kernel" prefix - Omit algorithm name since namespace provides context Reviewed By: mlunar-meta Differential Revision: D91983718
Summary: Move CtranKernelBroadcastArgs from gpe/CtranGpeDev.h to algos/Broadcast/Types.h as ctran::broadcast::KernelArgs. Part of KernelElem cleanup Phase 1. Naming follows the convention: - Remove "Ctran" prefix - Keep "Kernel" prefix - Omit algorithm name since namespace provides context Reviewed By: elvinlife Differential Revision: D91983717
Summary: Move CtranKernelReduceScatterArgs from gpe/CtranGpeDev.h to algos/ReduceScatter/Types.h as ctran::reducescatter::KernelArgs. Part of KernelElem cleanup Phase 1. Naming follows the convention: - Remove "Ctran" prefix - Keep "Kernel" prefix - Omit algorithm name since namespace provides context Reviewed By: elvinlife Differential Revision: D91983712
Summary: Move CtranKernelAllReduceArgs and CtranKernElemRole from gpe/CtranGpeDev.h to algos/AllReduce/Types.h as ctran::allreduce::KernelArgs and KernElemRole. Part of KernelElem cleanup Phase 1. Naming follows the convention: - Remove "Ctran" prefix - Keep "Kernel"/"KernElem" prefix - Omit algorithm name since namespace provides context Reviewed By: dsjohns2 Differential Revision: D91983714
minsii
force-pushed
the
export-D91983714
branch
from
d6f66a2 to
c88a6dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move CtranKernelAllReduceArgs and CtranKernElemRole from gpe/CtranGpeDev.h to
algos/AllReduce/Types.h as ctran::allreduce::KernelArgs and KernElemRole.
Part of KernelElem cleanup Phase 1.
Naming follows the convention:
Differential Revision: D91983714