-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
fix: xychart to support accented chars (7157) #7224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: xychart to support accented chars (7157) #7224
Conversation
… titles, add test to make sure accented chars supported
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7224 +/- ##
=======================================
Coverage 3.56% 3.56%
=======================================
Files 474 474
Lines 47577 47577
Branches 734 734
=======================================
Hits 1696 1696
Misses 45881 45881
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
📑 Summary
Allow
xychartto parse accented Latin characters in axis labels and titles.Previously, the lexer only treated ASCII letters (
A–Z,a–z) as validALPHAtokens. As a result, common accented characters likeéorècaused “Unrecognized text” errors in x-axis categories and y-axis titles.This PR expands the
ALPHAtoken to include accented Latin characters and adds a parser spec to ensurexychartaccepts them correctly.Resolves #7157
📏 Design Decisions
ALPHArule inxychart.jisonfrom:[A-Za-z]+to:
[A-Za-zÀ-ÖØ-öø-ÿ]+so that common accented Latin characters are recognized as part of words, while preserving existing behavior for ASCII labels.
xychartparsing behavior.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.