Skip to content

Conversation

@estulpz202
Copy link

@estulpz202 estulpz202 commented Dec 7, 2025

📑 Summary

Allow xychart to parse accented Latin characters in axis labels and titles.

Previously, the lexer only treated ASCII letters (A–Z, a–z) as valid ALPHA tokens. As a result, common accented characters like é or è caused “Unrecognized text” errors in x-axis categories and y-axis titles.

This PR expands the ALPHA token to include accented Latin characters and adds a parser spec to ensure xychart accepts them correctly.

Resolves #7157

📏 Design Decisions

  • Updated the ALPHA rule in xychart.jison from:
    • [A-Za-z]+
      to:
    • [A-Za-zÀ-ÖØ-öø-ÿ]+
      so that common accented Latin characters are recognized as part of words, while preserving existing behavior for ASCII labels.
  • Kept the change narrowly scoped to the lexer token definition and its tests to minimize the risk of regressions in other xychart parsing behavior.

📋 Tasks

Make sure you

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2025

⚠️ No Changeset found

Latest commit: 2c70098

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Dec 7, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 2c70098
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6934dd1187073b00088efb55
😎 Deploy Preview https://deploy-preview-7224--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Dec 7, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 7, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7224

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7224

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7224

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7224

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7224

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7224

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7224

commit: 2c70098

@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.56%. Comparing base (a3a5040) to head (2c70098).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7224   +/-   ##
=======================================
  Coverage     3.56%   3.56%           
=======================================
  Files          474     474           
  Lines        47577   47577           
  Branches       734     734           
=======================================
  Hits          1696    1696           
  Misses       45881   45881           
Flag Coverage Δ
unit 3.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci
Copy link

argos-ci bot commented Dec 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Dec 7, 2025, 1:59 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug / Error Something isn't working or is incorrect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XY Chart: accented character is an error in a word

3 participants