-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
fix: refresh gitGraph config per render (7126) #7223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: refresh gitGraph config per render (7126) #7223
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7223 +/- ##
=======================================
Coverage 3.56% 3.56%
=======================================
Files 474 473 -1
Lines 47577 47566 -11
Branches 734 734
=======================================
Hits 1696 1696
+ Misses 45881 45870 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
📑 Summary
Ensure
gitGraphrespects the latest Mermaid configuration on every render.Previously,
gitGraphRendererread the Mermaid config once at module load and cachedgitGraphoptions. As a result,rotateCommitLabel,showBranches, andparallelCommitsappeared to be ignored after the first render in interactive environments (such as the live editor) where users tweak the config without a full page reload.This PR refreshes the
gitGraphconfig insidedrawso each render uses the latest settings.Resolves #7126
📏 Design Decisions
DEFAULT_GITGRAPH_CONFIGto a mutable variable and refreshes it at the start ofdrawThis keeps the behavior of the first render unchanged while ensuring that subsequent renders pick up any updated gitGraph options in the Mermaid config.
GitGraph config not found.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.