-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
fix: Allow C4 Dynamic multiple interactions #7219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: Allow C4 Dynamic multiple interactions #7219
Conversation
🦋 Changeset detectedLatest commit: 848b1ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
C4 Dynamic allows for multiple interactions between the same components. Before, a second interaction was merged with the previous interaction, which was incorrect.
c3978a2 to
848b1ee
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7219 +/- ##
=======================================
Coverage 3.56% 3.56%
=======================================
Files 473 473
Lines 47566 47561 -5
Branches 734 734
=======================================
Hits 1696 1696
+ Misses 45870 45865 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
C4 Dynamic allows for multiple interactions
between the same components. Before, a second
interaction was merged with the previous
interaction, which was incorrect.
📑 Summary
Brief description about the content of your PR.
Resolves #7183
📏 Design Decisions
The parser cannot determine if relations are duplicate and should be merged easily because the
c4Typeis not parsed. Therefore do not merge relations in the database. If we want to keep merging relationships for other C4 diagram types, that could be solved in the renderer.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.