Skip to content

Conversation

@aristotelos
Copy link

@aristotelos aristotelos commented Dec 5, 2025

C4 Dynamic allows for multiple interactions
between the same components. Before, a second
interaction was merged with the previous
interaction, which was incorrect.

📑 Summary

Brief description about the content of your PR.

Resolves #7183

📏 Design Decisions

The parser cannot determine if relations are duplicate and should be merged easily because the c4Type is not parsed. Therefore do not merge relations in the database. If we want to keep merging relationships for other C4 diagram types, that could be solved in the renderer.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

🦋 Changeset detected

Latest commit: 848b1ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 848b1ee
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/693280abc0e0d700087d81a1
😎 Deploy Preview https://deploy-preview-7219--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 5, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7219

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7219

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7219

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7219

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7219

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7219

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7219

commit: 848b1ee

C4 Dynamic allows for multiple interactions
between the same components. Before, a second
interaction was merged with the previous
interaction, which was incorrect.
@aristotelos aristotelos force-pushed the fix-c4-dynamic-multiple-interactions branch from c3978a2 to 848b1ee Compare December 5, 2025 06:50
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 3.56%. Comparing base (39d070f) to head (848b1ee).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/c4/c4Db.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7219   +/-   ##
=======================================
  Coverage     3.56%   3.56%           
=======================================
  Files          473     473           
  Lines        47566   47561    -5     
  Branches       734     734           
=======================================
  Hits          1696    1696           
+ Misses       45870   45865    -5     
Flag Coverage Δ
unit 3.56% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/c4/c4Db.js 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci
Copy link

argos-ci bot commented Dec 5, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Dec 5, 2025, 7:07 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C4 Dynamic Diagram multiple interactions

1 participant