-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
fix: Fix C4 model font size on Firefox #7170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: Fix C4 model font size on Firefox #7170
Conversation
🦋 Changeset detectedLatest commit: 318bd12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7170 +/- ##
==========================================
+ Coverage 3.55% 3.56% +0.01%
==========================================
Files 474 474
Lines 47508 47579 +71
Branches 731 734 +3
==========================================
+ Hits 1687 1696 +9
- Misses 45821 45883 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Fix that font size was not applied in Firefox, resulting in badly rendered C4 model descriptions.
a9018ee to
318bd12
Compare
Fix that font size was not applied in Firefox, resulting in badly rendered C4 model descriptions.
📑 Summary
Fix that numeric font size was not applied in Firefox. See how https://mermaid.js.org/syntax/c4.html is rendered in Firefox.
Fixes #7182.
📏 Design Decisions
Add "px" if font size is numeric.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.