Potential fix for code scanning alert no. 2: Incomplete string escaping or encoding #8264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mantinedev/mantine/security/code-scanning/2
To fully escape dangerous characters in the CSS variable interpolation, we must escape both single quotes and backslashes within the
labelstring. The best approach is to first escape all backslashes (\), then escape single quotes ('), since newly-added backslashes could interfere with subsequent escaping if done out of order. Both should use the global regex flag to capture all instances in the string.Edit only line 47, within
packages/@mantine/spotlight/src/SpotlightActionsGroup.tsx, to ensurelabelis properly escaped. No additional dependencies are required because JavaScript's built-in string replace with regular expressions suffices.Suggested fixes powered by Copilot Autofix. Review carefully before merging.