LDEV-5903 fix PageSourcePool leak when PhysicalClassLoader flushes #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspitzer
force-pushed
the
LDEV-5903-redux
branch
from
8957bc9 to
c80979e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple Mappings can share the same PhysicalClassLoader (same classRootDirectory), but the classloader only held a reference to a single PageSourcePool. When the classloader flushed, only that one pool's pages were cleared - other mappings' pools were never notified, causing stale Page references to accumulate.
The fix changes pageSourcePool from a single field to a Set, with mappings registering their pools via registerPageSourcePool(). On flush, all registered pools are cleared.