Add test for CheckAccessFullyMapped #609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for CheckAccessFullyMapped. It builds on the previous test that was added to test the partially mapped / reserved resources infrastructure.
The test can be extended and simultaneously used to test both the reserved resources infrastructure and CheckAccessFullyMapped, the former implicitly and the latter explicitly.
It also tests unsigned ints directly given to CheckAccessFullyMapped, validating results for non-status inputs.
Fixes #181
Clang is currently failing, but will pass once llvm/llvm-project#170949 goes in.