Remove NV-Reconvergence-Issue-320 XFAIL from Feature/WaveOps/WaveIsFirstLane.test
#608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icohedron
added
the
test-all
Contributor
Author
|
Is there a way to match on driver version and XFAIL if the driver version is < 591.44? Maybe we don't want to remove the XFAIL altogether and instead XFAIL if the driver version is less than 591.44 on a 50-series NVIDIA GPU. |
bogner
approved these changes
Dec 5, 2025
Collaborator
bogner
left a comment
bogner
left a comment
There was a problem hiding this comment.
I think it's probably okay to assume latest drivers, otherwise the testing matrix gets pretty unwieldy. This LGTM as is.
llvm-beanz
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NVIDIA Reconvergence issue appears to be fixed with driver version 591.44 and the test now XPASSes. So this PR removes the XFAIL and the corresponding feature from the lit.cfg
Feature/WaveOps/WaveIsFirstLane.testfails under D3D12 on NV 50-series #320