Skip to content

Conversation

@farzonl
Copy link
Member

@farzonl farzonl commented Sep 30, 2025

fixes #457
fixes #458
fixes #459

@farzonl
Copy link
Member Author

farzonl commented Oct 3, 2025

On failure is in the Warp setup cmake action for arm64. The failure is not related to this pr.

-- Fetching WARP Latest Known Good for arm64 (1.0.15)...
CMake Error: tar: *dll: Not found in archive
CMake Error: tar: *pdb: Not found in archive
CMake Error at C:/Users/github/dev/_work/offload-test-suite/offload-test-suite/OffloadTest/cmake/modules/Warp.cmake:45 (file):
  file failed to extract:
  C:/Users/github/dev/_work/offload-test-suite/offload-test-suite/llvm-project/build/tools/OffloadTest/Microsoft.Direct3D.WARP.1.0.15.zip

Copy link
Collaborator

@spall spall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@hekota hekota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT - just a few nits and a suggestion to use ZeroInitSize for initialization and Results: for checking expected output. I've only put comments in the first file, but it applies to all.

@farzonl farzonl merged commit a47948d into llvm:main Oct 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants