-
Notifications
You must be signed in to change notification settings - Fork 28
[matrix] add tests for various matrix frontend features #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
On failure is in the Warp setup cmake action for arm64. The failure is not related to this pr. |
spall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hekota
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT - just a few nits and a suggestion to use ZeroInitSize for initialization and Results: for checking expected output. I've only put comments in the first file, but it applies to all.
fixes #457
fixes #458
fixes #459