chore: comprehensive code cleanup #242
Merged
+3,877
−3,080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess users - Update MfaDisableDialog to check user.hasPassword - Show OAuth "Verify with [Provider]" button for passwordless users - Add useInitiateDisableMfaOAuth hook for OAuth redirect flow - Set up Vitest testing infrastructure for frontend - Add 6 tests covering password and OAuth verification paths - Fix AdminTeamDetail schema to include memberCount and ownerEmail (converted from @Property to fields using __post_init__)
- Add anyio and pytest-anyio to test dependencies - Convert session-scoped async fixtures (engine, db_schema) to sync - Convert _patch_db fixture to sync (no async work needed) - Add pytestmark = pytest.mark.anyio to all test files and conftest files Fixes CI test failures caused by pytest 9's stricter handling of async fixtures without proper plugin support.
…ons.py and test_log.py
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major code cleanup and overdo review