Align options #706
Merged
Align options #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
requested review from
ezilber-akamai and
ykim-akamai
and removed request for
a team
mssalvatore
force-pushed
the
align-options
branch
3 times, most recently
from
bf27050 to
e2f6220
Compare
mssalvatore
force-pushed
the
align-options
branch
from
e2f6220 to
984f7c1
Compare
mssalvatore
force-pushed
the
align-options
branch
from
984f7c1 to
425eb4e
Compare
ezilber-akamai
approved these changes
Jan 8, 2025
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Tested this out locally and it looks great. Thank you for the contribution!
ykim-akamai
approved these changes
Jan 8, 2025
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, tested configuration steps locally and it looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Configuration options are not aligned when presented to the user. In the below screenshot, you'll notice a shift in alignment when the option number increases from 9 to 10. A similar shift occurs when the numbers increase from 99 to 100. This PR aligns the options.
✔️ How to Test
Reproduce the issue by running
linode-cli configure. Test the fix by runningmake testunit.📷 Preview
< 100 options
With whitespace characters (for clarity)
1,000 options