[admin-tool] Refactor DumpAdminMessages to log messages as they are received #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed dumpAdminMessages() to log messages immediately instead of buffering - Added Logger similar to KafkaTopicDumper pattern - Changed return type from List<AdminOperationInfo> to int (count) - Removed unused AdminOperationInfo inner class - Moved getPubSubConsumerProperties to AdminTool, then replaced with PubSubUtil.addPubSubBrokerAddress - Updated AdminTool.dumpAdminMessages() to use try-with-resources - Updated tests to work with new return type
There was a problem hiding this comment.
Pull request overview
This PR refactors the DumpAdminMessages utility to log admin messages as they are received instead of buffering them in memory. The changes improve resource management and follow existing patterns in the codebase.
Changes:
- Replaced buffering with immediate logging of admin messages using Log4j logger
- Added try-with-resources for proper consumer cleanup
- Consolidated SSL validation logic by replacing
getPubSubConsumerPropertieswith existing utilities
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DumpAdminMessages.java | Removed AdminOperationInfo inner class, changed return type to int, added logger for immediate message output, removed redundant getPubSubConsumerProperties method |
| AdminTool.java | Added try-with-resources for consumer management, replaced custom method with PubSubUtil.addPubSubBrokerAddress |
| TestAdminToolConsumption.java | Updated test to verify integer count instead of list size |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update ProducerMd logging to use expanded format matching KafkaTopicDumper:
ProducerMd:(guid:{},seg:{},seq:{},mts:{},lts:{}) instead of toString()
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...mon/src/integrationTest/java/com/linkedin/venice/integration/utils/VeniceClusterWrapper.java
Show resolved
Hide resolved
.../src/integrationTest/java/com/linkedin/venice/endToEnd/TestMultiDatacenterVenicePushJob.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[admin-tool] Refactor DumpAdminMessages to log messages as they are received
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?