Skip to content

Conversation

@tankyleo
Copy link
Contributor

Users have to pass this prefix to VssClient::new, otherwise the connection fails.

Users have to pass this prefix to `VssClient::new`, otherwise the
connection fails.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 17, 2026

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested a review from tnull January 17, 2026 02:20
@tankyleo
Copy link
Contributor Author

Unless we want to append the prefix to the string passed to VssClient::new ? In any case, I've caught myself forgetting to add this prefix multiple times

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@tnull tnull merged commit 022ee5e into lightningdevkit:main Jan 17, 2026
2 checks passed
@tnull
Copy link
Contributor

tnull commented Jan 17, 2026

Unless we want to append the prefix to the string passed to VssClient::new ? In any case, I've caught myself forgetting to add this prefix multiple times

We could consider adding it if it's absent, that is, if we're sure it will be always the same endpoint. However, that's orthogonal to this PR, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants