Skip to content

Add ROCm GPU backend support for stable-diffusion.cpp #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
makn87amd wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add ROCm GPU backend support for stable-diffusion.cpp #980

makn87amd wants to merge 1 commit into from

Conversation

@makn87amd
Copy link

@makn87amd makn87amd commented Jan 29, 2026

  • Add sdcpp_backend option with --sdcpp CLI flag and LEMONADE_SDCPP env var
  • Support 'cpu' (default) and 'rocm' backends for sd.cpp
  • Download ROCm-enabled sd.cpp binaries for AMD GPU acceleration
  • Add backend-specific versioning in backend_versions.json
  • Set PATH for ROCm DLLs on Windows for HIP runtime loading
  • Add api_image_gen_rocm.py example demonstrating ROCm image generation
  • Fix example script to use correct API parameters (model_name, model)

@makn87amd
Add ROCm GPU backend support for stable-diffusion.cpp
316448c 
- Add sdcpp_backend option with --sdcpp CLI flag and LEMONADE_SDCPP env var
- Support 'cpu' (default) and 'rocm' backends for sd.cpp
- Download ROCm-enabled sd.cpp binaries for AMD GPU acceleration
- Add backend-specific versioning in backend_versions.json
- Set PATH for ROCm DLLs on Windows for HIP runtime loading
- Add api_image_gen_rocm.py example demonstrating ROCm image generation
- Fix example script to use correct API parameters (model_name, model)
@makn87amd
Copy link
Author

makn87amd commented Jan 29, 2026

The example needs to be pruned. It was auto-generated and has a ton of helper functions

superm1
superm1 reviewed Feb 2, 2026
View reviewed changes
src/cpp/server/recipe_options.cpp
{"ctx_size", 4096},
{"llamacpp_backend", "vulkan"},
{"llamacpp_args", ""},
{"sdcpp_backend", "cpu"}, // ADDED: sd.cpp backend selection (cpu or rocm)
Copy link
Collaborator

@superm1 superm1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty noisy/pointless comment, no?

Copy link
Contributor

@jeremyfowers jeremyfowers Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look @superm1, but the PR is still in draft state. I would expect @makn87amd to clean up on his own prior to marking Ready for Review.

src/cpp/server/recipe_options.cpp
{"envname", "LEMONADE_LLAMACPP_ARGS"},
{"help", "Custom arguments to pass to llama-server (must not conflict with managed args)"}
}},
// ADDED: sd.cpp backend selection option
Copy link
Collaborator

@superm1 superm1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty noisy/pointless comment, no?

src/cpp/server/recipe_options.cpp
return {"ctx_size"};
} else if (recipe == "sd-cpp") {
return {"steps", "cfg_scale", "width", "height"};
// ADDED: Include sdcpp_backend for backend selection (cpu vs rocm)
Copy link
Collaborator

@superm1 superm1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty noisy/pointless comment, no?

src/cpp/server/router.cpp
} else if (model_info.recipe == "sd-cpp") {
std::cout << "[Router] Creating SDServer backend" << std::endl;
new_server = std::make_unique<backends::SDServer>(log_level_, model_manager_);
// ADDED: Pass sdcpp_backend from default_options_ to SDServer
Copy link
Collaborator

@superm1 superm1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty noisy/pointless comment, no?

src/cpp/server/recipe_options.cpp
{"option_name", "sdcpp_backend"},
{"type_name", "BACKEND"},
{"allowed_values", {"cpu", "rocm"}},
{"envname", "LEMONADE_SDCPP"},
Copy link
Collaborator

@superm1 superm1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add this new environment variable to data/lemonade.conf

src/cpp/server/backends/sd_server.cpp
Comment on lines +200 to +201
// macOS ARM build
filename = "sd-" + short_version + "-bin-Darwin-macOS-15.7.2-arm64.zip";
Copy link
Collaborator

@superm1 superm1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this actually going to be published initially? I feel like this should be in the #else block

src/cpp/server/backends/sd_server.cpp
// Helper to get the install directory for sd executable
static std::string get_sd_install_dir() {
return (fs::path(get_downloaded_bin_dir()) / "sd-cpp").string();
// ADDED: Include backend subdirectory to support multiple backends
Copy link
Collaborator

@superm1 superm1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noisy comment

src/cpp/server/backends/sd_server.cpp

// Helper to get stable-diffusion.cpp version from configuration
static std::string get_sd_version() {
// ADDED: Support for backend-specific versions (cpu vs rocm)
Copy link
Collaborator

@superm1 superm1 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noisy comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@superm1 superm1 superm1 left review comments

@danielholanda danielholanda Awaiting requested review from danielholanda

@ramkrishna2910 ramkrishna2910 Awaiting requested review from ramkrishna2910

@jeremyfowers jeremyfowers Awaiting requested review from jeremyfowers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@makn87amd @superm1 @jeremyfowers