Skip to content

Conversation

@majiayu000
Copy link
Contributor

Summary

  • Clear loop/iteration metadata when pasting node outside Loop/Iteration containers
  • Affected fields: isInLoop, loop_id, isInIteration, iteration_id, parentId
  • Node now behaves as an independent workflow node after pasting outside

Test plan

  • Copy a node from inside a Loop container
  • Paste it outside the Loop
  • Verify the "Exit Loop" option no longer appears
  • Verify the node can connect to other nodes in the main workflow

Fixes #29835

…e container

When copying a node from inside a Loop/Iteration and pasting it outside,
the node was retaining loop-specific metadata (isInLoop, loop_id,
isInIteration, iteration_id, parentId), causing it to still be treated
as a loop child with restricted connections.

This fix clears these metadata fields when pasting a single node outside
of Loop/Iteration containers, ensuring the node behaves as an independent
workflow node.

Fixes langgenius#29835
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 22, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @majiayu000, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where nodes copied from within a Loop or Iteration container would retain their container-specific metadata when pasted elsewhere in the workflow. The fix ensures that when a node is pasted outside of such a container, its associated loop and iteration metadata are cleared, allowing it to function as an independent and properly de-coupled element within the main workflow. This improves the predictability and correctness of workflow editing operations.

Highlights

  • Metadata Clearing: Implemented logic to automatically clear loop and iteration-specific metadata (such as isInLoop, loop_id, isInIteration, iteration_id, and parentId) from a node when it is pasted outside of its original Loop or Iteration container.
  • Node Independence: Ensures that nodes copied from within a nested block (Loop or Iteration) behave as independent workflow nodes when pasted into the main workflow, preventing them from retaining their previous container context.
  • Conditional Logic: Introduced a pastedToNestedBlock flag to accurately determine if a node is being pasted into another nested block or into the main workflow, triggering the metadata clearing only when necessary.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes the issue where loop/iteration metadata was not cleared when pasting a node outside its container. The logic to track whether a paste operation occurs within a nested block and subsequently clear the metadata is sound.

I've identified two related bugs in the existing logic for pasting nodes into nested containers, which could be addressed as part of this change to make the paste functionality more robust. My review comments provide details on these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copied node pasted outside Loop is still treated as loop child and restricted to Exit Loop

1 participant