-
Notifications
You must be signed in to change notification settings - Fork 19.5k
fix(workflow): clear loop/iteration metadata when pasting node outside container #29983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(workflow): clear loop/iteration metadata when pasting node outside container #29983
Conversation
…e container When copying a node from inside a Loop/Iteration and pasting it outside, the node was retaining loop-specific metadata (isInLoop, loop_id, isInIteration, iteration_id, parentId), causing it to still be treated as a loop child with restricted connections. This fix clears these metadata fields when pasting a single node outside of Loop/Iteration containers, ensuring the node behaves as an independent workflow node. Fixes langgenius#29835
Summary of ChangesHello @majiayu000, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where nodes copied from within a Loop or Iteration container would retain their container-specific metadata when pasted elsewhere in the workflow. The fix ensures that when a node is pasted outside of such a container, its associated loop and iteration metadata are cleared, allowing it to function as an independent and properly de-coupled element within the main workflow. This improves the predictability and correctness of workflow editing operations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the issue where loop/iteration metadata was not cleared when pasting a node outside its container. The logic to track whether a paste operation occurs within a nested block and subsequently clear the metadata is sound.
I've identified two related bugs in the existing logic for pasting nodes into nested containers, which could be addressed as part of this change to make the paste functionality more robust. My review comments provide details on these issues.
Summary
isInLoop,loop_id,isInIteration,iteration_id,parentIdTest plan
Fixes #29835