Skip to content

KEP-2258: Node log query promotion to stable (GA) #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jrvaldes wants to merge 3 commits into
base: master
Choose a base branch
from
Open

KEP-2258: Node log query promotion to stable (GA) #5874

jrvaldes wants to merge 3 commits into from
+188 −58

Conversation

@jrvaldes
Copy link

@jrvaldes jrvaldes commented Feb 2, 2026

  • One-line PR description:
  • Other comments:

@jrvaldes
KEP-2258: add kubelet_http_requests_total metric
4637da7 
this commit adds the existing kubelet_http_requests_total metric
to kep.yaml reusing existing infrastructure rather than
creating a new dedicated metric.

Node Log Query leverages the kubelet's existing
HTTP instrumentation that exposes kubelet_http_requests_total
for all HTTP endpoints and can be filtered by:
 kubelet_http_requests_total{path=~"/logs.*"}
@jrvaldes
KEP-2258: format and align with current KEP template
11d54ae 
this commit updates README.md with the current template
, include missing sections and fixes formatting issues.
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Feb 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from zylxjtu February 2, 2026 19:25
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2026

Welcome @jrvaldes!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Feb 2, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2026

Hi @jrvaldes. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2026
@jrvaldes jrvaldes force-pushed the node-log-query-stable-promotion branch from 7b1e920 to d591132 Compare February 2, 2026 19:46
@jrvaldes
Copy link
Author

jrvaldes commented Feb 2, 2026

/cc @marosset

@k8s-ci-robot k8s-ci-robot requested a review from marosset February 2, 2026 19:47
@jrvaldes jrvaldes force-pushed the node-log-query-stable-promotion branch from d591132 to 24c8dcf Compare February 2, 2026 19:51
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
Once this PR has been reviewed and has the lgtm label, please assign soltysh, zylxjtu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset
Copy link
Contributor

marosset commented Feb 3, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2026
@jrvaldes
Copy link
Author

jrvaldes commented Feb 3, 2026

/retest-required

@jrvaldes jrvaldes force-pushed the node-log-query-stable-promotion branch from 24c8dcf to f2cad84 Compare February 3, 2026 19:24
@jrvaldes
Copy link
Author

jrvaldes commented Feb 3, 2026

/cc tico88612

@tico88612
Copy link
Member

tico88612 commented Feb 4, 2026

Hi @jrvaldes, this KEP is already tracked by v1.36 Enhancement Team. (ref: #2258 (comment))

@jrvaldes jrvaldes mentioned this pull request Feb 4, 2026
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

@zylxjtu zylxjtu Awaiting requested review from zylxjtu

@marosset marosset Awaiting requested review from marosset

@tico88612 tico88612 Awaiting requested review from tico88612

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jrvaldes @k8s-ci-robot @marosset @tico88612