Check TEST mode response #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
actually, this patch is ignorable. we already reading 0x40 bytes and test mode's receiving bytes info looks meanless. |
d3m3vilurr
force-pushed
the
check-magic-value
branch
from
47309d6 to
20f601b
Compare
Original client send message with 0 size instead 4, but reading 0x40 bytes. Response data always start `App`
d3m3vilurr
force-pushed
the
check-magic-value
branch
from
20f601b to
c6ed298
Compare
Owner
|
The PR as it is looks okay, but the rest of the stuff that was initially there did not make sense to me, from what I understood of hidapi. I'll ping you on IRC about that stuff. |
Contributor
Author
|
I was pushed wrong commit at make pr. so current commit only have value checking logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original client send message with 0 size instead 4, but reading
0x40 bytes.
Response data always start
App