Skip to content

Add message to clarify that the developer does not need to manually u… #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NateWr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add message to clarify that the developer does not need to manually u… #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/release/createGithubRelease.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
* - Prompts the user to confirm they want to create a release on Github
* - Opens the URL for Github release prepopulated with the release info
* - Waits for the user to confirm they have published the release
*
* @notes
*
* @notes
* - We can not automatically know when the user has published the release so we require manual confirmation
* - using open({wait: true}) could be used but it triggers when the browser is closed (not the tab),
* also it does not work on windows
Expand Down Expand Up @@ -65,7 +65,7 @@ async function checkReleaseCreated() {
{
type: 'confirm',
name: 'releaseCreated',
message: `Once you publish the release on Github, type 'Yes' to proceed with the following steps.`,
message: `Once you publish the release on Github, type 'Yes' to proceed with the following steps. (Do not upload a release package. This will be done for you after you publish the release.)`,
default: false
}
])
Expand Down